Thanks Kees for the quick response. Just I have submitted those changes through patch v5. - Bhaskara >-----Original Message----- >From: Kees Cook <keescook@xxxxxxxxxxxx> >Sent: Wednesday, January 20, 2021 1:01 AM >To: Bhaskara Budiredla <bbudiredla@xxxxxxxxxxx> >Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>; Colin Cross ><ccross@xxxxxxxxxxx>; Tony Luck <tony.luck@xxxxxxxxx>; Sunil Kovvuri >Goutham <sgoutham@xxxxxxxxxxx>; linux-mmc@xxxxxxxxxxxxxxx; Linux >Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> >Subject: Re: [EXT] Re: [PATCH v4 1/2] mmc: Support kmsg dumper based on >pstore/blk > >On Tue, Jan 19, 2021 at 04:11:31AM +0000, Bhaskara Budiredla wrote: >> Do you see any issues to ACK this if the mmc pstore registration is >> through register_pstore_blk()? >> As Uffe said, eMMC would need to go through >> psblk_generic_blk_read()/write() instead of mmcpstore_read()/write(). > >I would be fine with that; yes. > >-- >Kees Cook
