RE: [PATCH] mmc: host: renesas_internal_dmac: add pre_req and post_req support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram-san,

> From: Yoshihiro Shimoda, Sent: Tuesday, December 15, 2020 2:03 PM
<snip>
> I'm sorry again and again. But, I realized the current patch breaks
> "force_pio" mode because tmio_mmc_pio_irq() doesn't take care of {pre,post}_req.
> So, I'll try to refactor tmio core to support {pre,post}_req().

I'm sorry. My fault injection code is bad. In other words, we don't need
to refactor tmio core.

I had added "goto force_pio;" in renesas_sdhi_internal_dmac_start_dma() yesterday.
However, I should have added "goto force_pio_with_unmap;" instead.
Otherwise, the driver unmaps the buffer after pio finished so that reading data
by pio was invalidated by dma_unmap_sg().

So, I'll submit v2 patch later.

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux