Hi Ulf wt., 24 lis 2020 o 12:31 Ulf Hansson <ulf.hansson@xxxxxxxxxx> napisał(a): > > On Fri, 20 Nov 2020 at 04:27, Marcin Wojtas <mw@xxxxxxxxxxxx> wrote: > > > > As a preparation for supporting ACPI, modify the driver > > to use the clk framework only when booting with DT - > > otherwise rely on the configuration done by firmware. > > For that purpose introduce also a custom SDHCI get_max_clock > > callback. > > > > Signed-off-by: Marcin Wojtas <mw@xxxxxxxxxxxx> > > [...] > > > @@ -561,9 +574,11 @@ static int xenon_probe(struct platform_device *pdev) > > pm_runtime_put_noidle(&pdev->dev); > > xenon_sdhc_unprepare(host); > > err_clk_axi: > > - clk_disable_unprepare(priv->axi_clk); > > + if (dev->of_node) > > + clk_disable_unprepare(priv->axi_clk); > > err_clk: > > - clk_disable_unprepare(pltfm_host->clk); > > + if (dev->of_node) > > + clk_disable_unprepare(pltfm_host->clk); > > There's no need to check the dev->of_node, I believe. The > clk_disable_unprepare() is capable of managing a NULL pointer as > in-parameter. > Indeed, clk_disable_unprepare() can handle the NULL pointers. I will wait a couple of days for other comments/remarks and will update this patch in v3. Best regards, Marcin
