Hi Ulf,
Thanks
>-----Original Message-----
>From: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>Sent: Tuesday, November 24, 2020 12:07 AM
>To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@xxxxxxxxx>
>Cc: linux-mmc@xxxxxxxxxxxxxxx; Linux ARM <linux-arm-
>kernel@xxxxxxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-
>kernel@xxxxxxxxxxxxxxx>; Hunter, Adrian <adrian.hunter@xxxxxxxxx>; Raja
>Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@xxxxxxxxx>; Wan
>Mohamad, Wan Ahmad Zainie
><wan.ahmad.zainie.wan.mohamad@xxxxxxxxx>; David E. Box
><david.e.box@xxxxxxxxxxxxxxx>
>Subject: Re: [PATCH v2 1/1] mmc: sdhci-of-arasan: Fix clock registration fail
>for Keem Bay SOC
>
>On Wed, 18 Nov 2020 at 05:01, <muhammad.husaini.zulkifli@xxxxxxxxx>
>wrote:
>>
>> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@xxxxxxxxx>
>>
>> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations
>> handling") introduces platform specific SDHCI clock operation. Each
>> platform should specify clock operations handlers.
>>
>> Commit 16ada730a759 ("mmc: sdhci-of-arasan: Modify clock operations
>> handling") and Commit 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support
>> for Intel Keem Bay") are merged about the same time. When doing
>> rebasing during the upstream process, Commit 16ada730a759 ("mmc:
>> sdhci-of-arasan: Modify clock operations handling") was not included.
>> This will result in sd clock registration failure for Keem Bay SOC Devices as
>clock operations handlers are not defined.
>>
>> This patch declares the clock operation for Keem Bay SOC Devices.
>> Add clk_ops for SD, EMMC and SDIO operations.
>>
>> Fixes: 36c6aadaae86 ("mmc: sdhci-of-arasan: Add support for Intel Keem
>> Bay")
>>
>> Signed-off-by: Muhammad Husaini Zulkifli
>> <muhammad.husaini.zulkifli@xxxxxxxxx>
>> Reviewed-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
>
>Applied for fixes and by adding a stable tag, thanks!
>
>Kind regards
>Uffe
>
>
>> ---
>> drivers/mmc/host/sdhci-of-arasan.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c
>> b/drivers/mmc/host/sdhci-of-arasan.c
>> index 829ccef87426..012d52e1abee 100644
>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>> @@ -1199,16 +1199,19 @@ static struct sdhci_arasan_of_data
>> sdhci_arasan_versal_data = { static struct sdhci_arasan_of_data
>intel_keembay_emmc_data = {
>> .soc_ctl_map = &intel_keembay_soc_ctl_map,
>> .pdata = &sdhci_keembay_emmc_pdata,
>> + .clk_ops = &arasan_clk_ops,
>> };
>>
>> static struct sdhci_arasan_of_data intel_keembay_sd_data = {
>> .soc_ctl_map = &intel_keembay_soc_ctl_map,
>> .pdata = &sdhci_keembay_sd_pdata,
>> + .clk_ops = &arasan_clk_ops,
>> };
>>
>> static struct sdhci_arasan_of_data intel_keembay_sdio_data = {
>> .soc_ctl_map = &intel_keembay_soc_ctl_map,
>> .pdata = &sdhci_keembay_sdio_pdata,
>> + .clk_ops = &arasan_clk_ops,
>> };
>>
>> static const struct of_device_id sdhci_arasan_of_match[] = {
>> --
>> 2.17.1
>>
