On Mon, Nov 23, 2020 at 08:00:35AM +0100, Michal Simek wrote: > > > On 20. 11. 20 19:37, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > > warnings by explicitly adding multiple break statements instead of > > letting the code fall through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx> > > --- > > drivers/mmc/host/sdhci-of-arasan.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > > index 829ccef87426..1f7e42b6ced5 100644 > > --- a/drivers/mmc/host/sdhci-of-arasan.c > > +++ b/drivers/mmc/host/sdhci-of-arasan.c > > @@ -627,6 +627,7 @@ static int sdhci_zynqmp_sdcardclk_set_phase(struct clk_hw *hw, int degrees) > > case MMC_TIMING_MMC_HS200: > > /* For 200MHz clock, 8 Taps are available */ > > tap_max = 8; > > + break; > > default: > > break; > > } > > @@ -695,6 +696,7 @@ static int sdhci_zynqmp_sampleclk_set_phase(struct clk_hw *hw, int degrees) > > case MMC_TIMING_MMC_HS200: > > /* For 200MHz clock, 30 Taps are available */ > > tap_max = 30; > > + break; > > default: > > break; > > } > > @@ -760,6 +762,7 @@ static int sdhci_versal_sdcardclk_set_phase(struct clk_hw *hw, int degrees) > > case MMC_TIMING_MMC_HS200: > > /* For 200MHz clock, 8 Taps are available */ > > tap_max = 8; > > + break; > > default: > > break; > > } > > @@ -831,6 +834,7 @@ static int sdhci_versal_sampleclk_set_phase(struct clk_hw *hw, int degrees) > > case MMC_TIMING_MMC_HS200: > > /* For 200MHz clock, 30 Taps are available */ > > tap_max = 30; > > + break; > > default: > > break; > > } > > > > No problem with it. > > Acked-by: Michal Simek <michal.simek@xxxxxxxxxx> Thanks, Michal. -- Gustavo
