Re: [PATCH] mmc: sdhci: tegra: fix wrong unit with busy_timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 16 Nov 2020 at 14:22, Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> 'busy_timeout' is in msecs, not in jiffies. Use the correct factor.
>
> Fixes: 5e958e4aacf4 ("sdhci: tegra: Implement Tegra specific set_timeout callback")
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Acked-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx>
> Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe


> ---
>
> Changes since RFC:
>
> * added acks
> * fixed typo causing build failure ("MSECS" instead of "MSEC")
>
>  drivers/mmc/host/sdhci-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index ed12aacb1c73..41d193fa77bb 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -1272,7 +1272,7 @@ static void tegra_sdhci_set_timeout(struct sdhci_host *host,
>          * busy wait mode.
>          */
>         val = sdhci_readl(host, SDHCI_TEGRA_VENDOR_MISC_CTRL);
> -       if (cmd && cmd->busy_timeout >= 11 * HZ)
> +       if (cmd && cmd->busy_timeout >= 11 * MSEC_PER_SEC)
>                 val |= SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT;
>         else
>                 val &= ~SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT;
> --
> 2.28.0
>



[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux