RE: [PATCH/RFC] mmc: core: disable power off notification when host is removed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ulf,

> From: Ulf Hansson, Sent: Friday, October 30, 2020 11:41 PM
> 
> On Fri, 30 Oct 2020 at 14:02, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> >
> > Hi Ulf,
> >
> > > From: Yoshihiro Shimoda, Sent: Tuesday, October 13, 2020 6:29 PM
> > >
> > > User is possible to turn the power off after a host was removed.
> > > So, disable the power off notification when a host is removed.
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > > ---
> > >  This topic was discussed in a few month ago [1], and now I could make
> > >  a patch for unbinding the mmc host. I'm not sure this is a correct way
> > >  so that I marked RFC.
> >
> > I would like to drop this patch because my colleague found an issue after
> > he applied this patch. The issue is the following timeout happened if
> > we unbind a host controller right after system suspend because
> > the _mmc_resume() was not called.
> 
> In principle we would like to run the similar operations at "remove"
> as during "system suspend".

Thank you for your feedback! Reusing _mmc_suspend() seems better than
my original code.

> >
> >         mmc0: Power Off Notification timed out, 100
> >
> > I'll make v2 patch in next week.
> 
> I will have a closer look at your v2, apologies for the delay in review.

No worries. I'll send v2 patch soon.

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux