+ Chunyan
On 14/10/20 1:32 pm, Jisheng Zhang wrote:
> Auto CMD Auto Select can only be used when v4_mode is enabled.
The SDHCI spec. doesn't seem to say that. AFAICS it refers only to v4.1 not
v4 mode.
>
> Fixes: 427b6514d095 ("mmc: sdhci: Add Auto CMD Auto Select support")
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@xxxxxxxxxxxxx>
> ---
> drivers/mmc/host/sdhci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 592a55a34b58..5e0ec5df4074 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1386,7 +1386,8 @@ static inline void sdhci_auto_cmd_select(struct sdhci_host *host,
> * Select' is recommended rather than use of 'Auto CMD12
> * Enable' or 'Auto CMD23 Enable'.
> */
> - if (host->version >= SDHCI_SPEC_410 && (use_cmd12 || use_cmd23)) {
> + if (host->version >= SDHCI_SPEC_410 && host->v4_mode &&
> + (use_cmd12 || use_cmd23)) {
> *mode |= SDHCI_TRNS_AUTO_SEL;
>
> ctrl2 = sdhci_readw(host, SDHCI_HOST_CONTROL2);
>
