Hi, On 06. 10. 20 13:13, Sudeep Holla wrote: > On Tue, Oct 06, 2020 at 01:22:31AM +0000, Zulkifli, Muhammad Husaini wrote: >> HI Sudeep and Michal, >> >> Yeah I believe it can work. I will create one header file in include/linux/firmware/intel/Keembay_firmware.h >> To handle this func and arasan controller can call this func. >> Are you guys ok with this? >> > > Sounds good to me. No change w.r.t arasan controller as it still needs > to call the same api(keembay_sd_voltage_selection), just w/o a firmware > driver for it. I am also fine with it. Just please make sure that driver can be compiled also on non ARM platforms. Thanks, Michal