On Wed, 2 Sep 2020 at 21:58, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > > > > On 9/2/2020 12:36 PM, Krzysztof Kozlowski wrote: > > Only -ENOENT from devm_clk_get() means that clock is not present in > > device tree. Other errors have their own meaning and should not be > > ignored. > > > > Simplify getting the clock which is in fact optional and also use > > dev_err_probe() for handling deferred. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > This is actually an open coded version of devm_clk_get_optional(), so > this is fine: devm_clk_get_optional() treats -ENOENT specifically, so it's not an exact open coded version. I think that's why Krzysztof prefered to get it tested on HW. > > Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx> Thanks! I am queuing this up for next, without waiting for explicit tests . There is time to get that from testing in linux-next anyway. Kind regards Uffe
