Hi,
On Fri, Aug 28, 2020 at 1:44 AM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>
> On Fri, 28 Aug 2020 at 08:08, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> >
> > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to
> > find the OPP table with error -ENODEV (i.e. OPP table not present for
> > the device). And we can call dev_pm_opp_of_remove_table()
> > unconditionally here.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>
> Replaced v1 with v2 on my next branch, thanks!
Actually, I don't see it on there yet, but at least the old broken v1
isn't there anymore. ;-)
I picked v2 and tried it on my sc7180-based device (which does have
OPP tables). It worked fine. Thus:
Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
I looked at the code and it looks right to me. Thus:
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Just to be sure, this patch doesn't depend on any changes for the opp
> core that are queued for v5.10?
Running atop mmc-next, I see the check for -ENODEV, so I'm gonna
assume that the required change is there.
$ git grep -A10 'void _dev_pm_opp_find_and_remove_table' -- drivers/opp/core.c
drivers/opp/core.c:void _dev_pm_opp_find_and_remove_table(struct device *dev)
drivers/opp/core.c-{
drivers/opp/core.c- struct opp_table *opp_table;
drivers/opp/core.c-
drivers/opp/core.c- /* Check for existing table for 'dev' */
drivers/opp/core.c- opp_table = _find_opp_table(dev);
drivers/opp/core.c- if (IS_ERR(opp_table)) {
drivers/opp/core.c- int error = PTR_ERR(opp_table);
drivers/opp/core.c-
drivers/opp/core.c- if (error != -ENODEV)
drivers/opp/core.c- WARN(1, "%s: opp_table: %d\n",
