On Fri, 28 Aug 2020 at 01:57, Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> wrote: > > On Thu, 27 Aug 2020 at 21:03, Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > > > The commit d05a7238fe1c ("mmc: sdhci-msm: Unconditionally call > > dev_pm_opp_of_remove_table()") works fine in the case where there is > > no OPP table. However, if there is an OPP table then > > dev_pm_opp_of_add_table() will return 0. Since 0 != -ENODEV then the > > "if (ret != -ENODEV)" will evaluate to true and we'll fall into the > > error case. Oops. > > > > Let's fix this. > > > > Fixes: d05a7238fe1c ("mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table()") > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > Reported-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> > > I will test this patch and report again on this email thread. Sorry this patch did not solve the reported problem. However, I would be testing the V2 set from Viresh Kumar. and report the test results on the other patch set [1]. [1] https://lore.kernel.org/linux-pm/cover.1598594714.git.viresh.kumar@xxxxxxxxxx