RE: [RFT 2/6] Revert "mmc: tmio: fix reset operation"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram-san,

> From: Wolfram Sang, Sent: Thursday, August 20, 2020 10:26 PM
> 
> This reverts commit a87852c6b8827b7fece78ae57d871d56e4348e30. It did fix
> the issue, but was building on top of already wrong assumptions. The
> driver missed that 'hw_reset' was only for resetting remote HW (card)
> and not for the IP core. Since we fixed that in a previous patch, we can
> now remove this patch to make it clear that 'reset' is for resetting the
> IP core only. Also, cancelling DMA will only be called when actually
> needed again. It will also allow for further cleanups and better
> readability. Note that in addition to the revert, the call in
> 'tmio_mmc_execute_tuning' will be converted, too, to maintain the
> current behaviour.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux