Re: [PATCH 1/6] md: switch to ->check_events for media change notifications

[Guoqing Jiang <guoqing.jiang@xxxxxxxxxxxxxxx>]

On 7/8/20 3:23 PM, Matthew Wilcox wrote:
> On Wed, Jul 08, 2020 at 03:17:31PM +0200, Guoqing Jiang wrote:
> > On 7/8/20 2:25 PM, Christoph Hellwig wrote:
> > > -static int md_media_changed(struct gendisk *disk)
> > > -{
> > > -	struct mddev *mddev = disk->private_data;
> > > -
> > > -	return mddev->changed;
> > > -}
> > Maybe we can remove "changed" from struct mddev since no one reads it
> > after the change.
> You missed this hunk:
>
> +static unsigned int md_check_events(struct gendisk *disk, unsigned int clearing)
>   {
>          struct mddev *mddev = disk->private_data;
> +	unsigned int ret = 0;
>
> +	if (mddev->changed)
> +               ret = DISK_EVENT_MEDIA_CHANGE;
>          mddev->changed = 0;
> -	return 0;
> +	return ret;
>   }

Yes, sorry for the noise.

Thanks,
Guoqing