Hi, On 23.06.2020 06:06, haibo.chen@xxxxxxx wrote: > From: Haibo Chen <haibo.chen@xxxxxxx> > > of_match_node() has the opportunity to return NULL, so need to > dereference null return value. > This is reported by Coverity. > > Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx> There is no point in such check for a NULL. The driver won't be instantiated/probed if there is no matching node found first by the upper level framework. If you really want to make this code cleaner, please change it to use of_device_get_match_data(). > --- > drivers/mmc/host/dw_mmc-exynos.c | 5 +++-- > drivers/mmc/host/dw_mmc-k3.c | 5 +++-- > drivers/mmc/host/dw_mmc-pltfm.c | 3 ++- > drivers/mmc/host/sdhci-of-arasan.c | 2 ++ > 4 files changed, 10 insertions(+), 5 deletions(-) > ... Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
