On Tue, 19 May 2020 at 13:35, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > This means dev_pm_domain_start() is needed only for the SDHI renesas > > variants. But on the other hand, it doesn't hurt for the others (the > > uniphier-sd variant doesn't even use runtime PM as confirmed by > > Yamada-san). > > > > I don't have a strong opinion, but it looks like we can either apply > > $subject patch as is, or modify it to make dev_pm_domain_start() be > > called only for the SDHI renesas variants. > > > > What do you prefer? > > Dealing with PM is confusing often enough. To keep it simple, I'd > suggest to avoid unneeded calls. It may take a while later to rediscover > if this call is essential or not. So, for the uniphier case, we know it > is not needed. If we agree on a best effort basis that it is also not > needed for tmio_mmc, then I think we should keep it only for Renesas > SDHI. Alright, I re-spin the series taking into account what has been said. Then I wait for your tested/reviewed-by tags before applying. Kind regards Uffe
