On 4/20/20 10:18 AM, Ulf Hansson wrote: > On Fri, 17 Apr 2020 at 17:33, Marek Vasut <marex@xxxxxxx> wrote: >> >> On 4/17/20 11:30 AM, Ulf Hansson wrote: >>> On Thu, 16 Apr 2020 at 18:36, Marek Vasut <marex@xxxxxxx> wrote: >>>> >>>> Patch all drivers which use mmc_regulator_set_vqmmc() and prepare them for >>>> the fact that mmc_regulator_set_vqmmc() can return a value > 0, which would >>>> happen if the signal voltage switch did NOT happen, because the voltage was >>>> already set correctly. >>>> >>>> Signed-off-by: Marek Vasut <marex@xxxxxxx> >>>> Cc: Alexandre Torgue <alexandre.torgue@xxxxxx> >>>> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> >>>> Cc: Ludovic Barre <ludovic.barre@xxxxxx> >>>> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> >>>> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx> >>>> Cc: Patrice Chotard <patrice.chotard@xxxxxx> >>>> Cc: Patrick Delaunay <patrick.delaunay@xxxxxx> >>>> Cc: Russell King <linux@xxxxxxxxxxxxxxx> >>>> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx> >>>> Cc: linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx >>>> To: linux-mmc@xxxxxxxxxxxxxxx >>> >>> Applied for next, thanks! >>> >>> I took the liberty to re-work and simplify some of the code, please >>> have a look at my next branch to make sure I didn't screw something >>> up. >> >> Where is your next branch ? > > It's listed in the MAINTAINERS file. > > git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git All right, this one. The adjustments look OK, thanks. I noticed this one in mtk-sd.c: /* Apply different pinctrl settings for different signal voltage */ if (ios->signal_voltage == MMC_SIGNAL_VOLTAGE_180) pinctrl_select_state(host->pinctrl, host->pins_uhs); else pinctrl_select_state(host->pinctrl, host->pins_default); I would almost think that the MTK platforms would support 1V2 modes too, so the above should rather be: if (ios->signal_voltage == MMC_SIGNAL_VOLTAGE_330) pinctrl_select_state(host->pinctrl, host->pins_default); else pinctrl_select_state(host->pinctrl, host->pins_uhs); But I have no hardware to test, and it's a topic for another patch.
