On Wed, 8 Apr 2020 at 11:46, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > > SDHI (with SCC) has a mechanism to select an optimal TAP even if all > were considered good during the tuning process. This series implements > support for it. Before that, some refactoring of 'best TAP selection' is > done to avoid code duplication and get more understandable code. > > This work is based on BSP patches by Masaharu Hayakawa and Takeshi > Saito. It is built on top of mmc/next. For convenience, a branch is > here: > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/new_manual_calib > > It has been tested on Renesas Salvator-XS boards (R-Car M3-N and R-Car > H3 ES2.0). There were no regressions detected. HS400 could be tuned the > same way, and checksumming large files still works. > > And while this series is useful by itself, it is also the last > prerequisite to implement some 'bad tap avoidance' on top which is what > we are originally aiming for. > > Note about backporting: The super useful iterator > bitmap_for_each_set_region() is only available since v5.6. If you want > that before, you need to backport the needed bits of e837dfde15a4 > ("bitmap: genericize percpu bitmap region iterators"), too. > > Thank you to Shimoda-san for his valuable input since the RFT version > of this patchset (see patch 1 for details)! > > Kind regards, > > Wolfram > > Wolfram Sang (3): > mmc: renesas_sdhi: refactor calculation of best TAP > mmc: renesas_sdhi: clarify handling of selecting TAPs > mmc: renesas_sdhi: improve TAP selection if all TAPs are good > > drivers/mmc/host/renesas_sdhi.h | 2 + > drivers/mmc/host/renesas_sdhi_core.c | 64 ++++++++++++++-------------- > 2 files changed, 34 insertions(+), 32 deletions(-) > > -- > 2.20.1 > Applied for next, thanks! Kind regards Uffe