On Tue, Mar 17, 2020 at 12:58:35PM +0100, Ulf Hansson wrote: > On Tue, 17 Mar 2020 at 03:45, 吳昊澄 Ricky <ricky_wu@xxxxxxxxxxx> wrote: > > > > > > > -----Original Message----- > > > From: Ulf Hansson [mailto:ulf.hansson@xxxxxxxxxx] > > > Sent: Monday, March 16, 2020 10:17 PM > > > To: 吳昊澄 Ricky > > > Cc: linux-mmc@xxxxxxxxxxxxxxx; Linux Kernel Mailing List; Arnd Bergmann; Greg > > > Kroah-Hartman > > > Subject: Re: [PATCH] mmc: rtsx: Fixed TX/RX register and optimized TX > > > parameter > > > > > > On Mon, 16 Mar 2020 at 03:52, <ricky_wu@xxxxxxxxxxx> wrote: > > > > > > > > From: Ricky Wu <ricky_wu@xxxxxxxxxxx> > > > > > > > > Fixed sd_change_phase TX/RX register > > > > Optimized rts522a rts524a rts525a rts5260 rts5261 TX initial parameter > > > > > > I don't understand what this actually fixes. Can you try to elaborate > > > a bit on this, please? > > > > > > Do you think this is needed for stable, then why? > > > > Yes, I think it need patch to stable > > > > In function sd_change_phase() whether it is TX or RX always write the same register(TX), so patch this function make RX and TX can change well. > > At mmc stack mechanism do not tuning TX phase, so need give a stable parameter for TX phase(sdr104 sdr50 ddr50) at initial. > > Alright, I took the liberty to clarify the changelog a bit according > to this. Please have a look at my fixes branch and tell me if I should > do some additional changes of the changelog. > > Applied for fixes and by adding a stable tag, thanks! > > Arnd, Greg, so I am picking this via my mmc tree, please shout at me > (or ack it) if you have any concerns with this. :-) No concerns at all! Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
