On Thu, Mar 05, 2020 at 11:52:04AM +0100, Ulf Hansson wrote: > > It really is not the job of the upper level driver to allocate the > > dma params. This should be done by the bus driver. > > I agree that allocating the dma_parms doesn't belong in the mmc block > queue layer. > > However, it seems silly that each an every mmc host driver needs to do > this themselves. So, perhaps we could manage this from > mmc_alloc_host(), which is a common interface that mmc host drivers > calls during initialization. Neither mmc drivers nor the mmc core should allocate dma_params ever. This should be once in their bus providers.