On Thu, 13 Feb 2020 at 15:42, Ludovic BARRE <ludovic.barre@xxxxxx> wrote: > > Hi Ulf > > Le 2/13/20 à 7:23 AM, Baolin Wang a écrit : > > On Tue, Feb 11, 2020 at 9:17 PM Baolin Wang <baolin.wang7@xxxxxxxxx> wrote: > >> > >> Hi Ulf, > >> > >> On Tue, Feb 4, 2020 at 4:55 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > >>> > >>> There exists several separate variants of polling loops, used to detect when > >>> the card stop signals busy for various operations, in the mmc core. All of them > >>> have different issues that needs to be fixed. > >>> > >>> The intent with this series, is to address some of these problems, via first > >>> improving the mmc_poll_for_busy() function, then consolidate code by moving > >>> more users to it. > >>> > >>> While I was working on this, I stumbled over some code here and there, that > >>> deserved some cleanup, hence I also folded in a couple of patches for this. > >>> > >>> So far, I have only managed to extensively test the updated mmc_poll_for_busy() > >>> function for CMD6 commands. Some tests for erase/trim/discard and for > >>> HPI+sanitize are needed. > >>> > >>> Note that, there are still separate polling loops in the mmc block layer, but > >>> moving that to mmc_poll_for_busy() involves some additional work. I am looking > >>> into that as a next step. > >>> > >>> Please help review and test! > >> > >> That will be help if you can supply one git branch to fetch these > >> patches :), and I will help to do some testing on my platform. > > > > I've tested on my platform, incuding reading, writing, mounting and > > running all cases in mmc_test.c, and I did not find any problem. So > > please feel free to add my test tag. Thanks. > > > > Tested on mmci: sdmmc variant with/out MMC_CAP_WAIT_WHILE_BUSY > and I see no regression. > After series review, I've just a comment on patch 01/12 > (code/comment alignment 32-64) > > Tested-by: Ludovic Barre <ludovic.barre@xxxxxx> > Reviewed-by: Ludovic Barre <ludovic.barre@xxxxxx> Thanks a lot, much appreciated! [...] Kind regards Uffe
