Re: [PATCH 01/12] mmc: core: Throttle polling rate for CMD6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 12 Feb 2020 at 14:51, Ludovic BARRE <ludovic.barre@xxxxxx> wrote:
>
> hi Ulf
>
> Le 2/4/20 à 9:54 AM, Ulf Hansson a écrit :
> > In mmc_poll_for_busy() we loop continuously, either by sending a CMD13 or
> > by invoking the ->card_busy() host ops, as to detect when the card stops
> > signaling busy. This behaviour is problematic as it may cause CPU hogging,
> > especially when the busy signal time reaches beyond a few ms.
> >
> > Let's fix the issue by adding a throttling mechanism, that inserts a
> > usleep_range() in between the polling attempts. The sleep range starts at
> > 16-32us, but increases for each loop by a factor of 2, up until the range
>
> Just to align comment and code: in the code the first usleep range start
> at 32-64us.

Yeah, good point, thanks. I was trying different values, but forgot to
update the commit message. :-)

Other than that, does the change look good to you?

[...]

Kind regards
Uffe




[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux