Re: [RFC PATCH 1/6] mmc: tmio: refactor tuning execution into SDHI driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Niklas,

thanks for the review!

> > +		ret = mmc_send_tuning(host->mmc, opcode, NULL);
> > +		if (ret == 0)
> 
> The variable ret is only used here after the refactor so you could 
> possibly drop it and just check mmc_send_tuning() == 0. With or without 

Yeah, makes sense. I will fix it.

Regards,

   Wolfram

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux