Hi Wolfram,
Thanks for your work.
On 2020-01-29 21:37:06 +0100, Wolfram Sang wrote:
> check_scc_error() is too Renesas specific. Let's just call it
> check_retune() to make it also easier understandable what it does.
> Only a rename, no functional change.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
> drivers/mmc/host/renesas_sdhi_core.c | 2 +-
> drivers/mmc/host/tmio_mmc.h | 2 +-
> drivers/mmc/host/tmio_mmc_core.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index d63aeb35bd0b..24ee8ac1fe21 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -899,7 +899,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
>
> host->execute_tuning = renesas_sdhi_execute_tuning;
> host->select_tuning = renesas_sdhi_select_tuning;
> - host->check_scc_error = renesas_sdhi_check_scc_error;
> + host->check_retune = renesas_sdhi_check_scc_error;
> host->prepare_hs400_tuning =
> renesas_sdhi_prepare_hs400_tuning;
> host->hs400_downgrade = renesas_sdhi_disable_scc;
> diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
> index bfebbe368f02..bdb9973981ff 100644
> --- a/drivers/mmc/host/tmio_mmc.h
> +++ b/drivers/mmc/host/tmio_mmc.h
> @@ -176,7 +176,7 @@ struct tmio_mmc_host {
> int (*write16_hook)(struct tmio_mmc_host *host, int addr);
> void (*reset)(struct tmio_mmc_host *host);
> void (*hw_reset)(struct tmio_mmc_host *host);
> - bool (*check_scc_error)(struct tmio_mmc_host *host);
> + bool (*check_retune)(struct tmio_mmc_host *host);
>
> /*
> * Mandatory callback for tuning to occur which is optional for SDR50
> diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
> index 593f88cafb6e..3cacb516a66e 100644
> --- a/drivers/mmc/host/tmio_mmc_core.c
> +++ b/drivers/mmc/host/tmio_mmc_core.c
> @@ -818,8 +818,8 @@ static void tmio_mmc_finish_request(struct tmio_mmc_host *host)
> if (mrq->cmd->error || (mrq->data && mrq->data->error))
> tmio_mmc_abort_dma(host);
>
> - /* SCC error means retune, but executed command was still successful */
> - if (host->check_scc_error && host->check_scc_error(host))
> + /* Error means retune, but executed command was still successful */
> + if (host->check_retune && host->check_retune(host))
> mmc_retune_needed(host->mmc);
>
> /* If SET_BLOCK_COUNT, continue with main command */
> --
> 2.20.1
>
--
Regards,
Niklas Söderlund
