On 8/01/20 4:32 pm, Faiz Abbas wrote: > The MMC/SD controllers on am65x and j721e don't in fact detect the write > protect line as inverted. No issues were detected because of this > because the sdwp line is not connected on any of the evms. Fix this by > removing the flag. > > Fixes: 1accbced1c32 ("mmc: sdhci_am654: Add Support for 4 bit IP on J721E") > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Faiz Abbas <faiz_abbas@xxxxxx> Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> > --- > drivers/mmc/host/sdhci_am654.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c > index b8e897e31e2e..2d38b1e12a7e 100644 > --- a/drivers/mmc/host/sdhci_am654.c > +++ b/drivers/mmc/host/sdhci_am654.c > @@ -253,8 +253,7 @@ static struct sdhci_ops sdhci_am654_ops = { > > static const struct sdhci_pltfm_data sdhci_am654_pdata = { > .ops = &sdhci_am654_ops, > - .quirks = SDHCI_QUIRK_INVERTED_WRITE_PROTECT | > - SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, > + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, > .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, > }; > > @@ -290,8 +289,7 @@ static struct sdhci_ops sdhci_j721e_8bit_ops = { > > static const struct sdhci_pltfm_data sdhci_j721e_8bit_pdata = { > .ops = &sdhci_j721e_8bit_ops, > - .quirks = SDHCI_QUIRK_INVERTED_WRITE_PROTECT | > - SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, > + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, > .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, > }; > > @@ -314,8 +312,7 @@ static struct sdhci_ops sdhci_j721e_4bit_ops = { > > static const struct sdhci_pltfm_data sdhci_j721e_4bit_pdata = { > .ops = &sdhci_j721e_4bit_ops, > - .quirks = SDHCI_QUIRK_INVERTED_WRITE_PROTECT | > - SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, > + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, > .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, > }; > >