Hi Ulf, On Thu, 19 Dec 2019 at 23:22, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > > + linux-mmc > > On Thu, 19 Dec 2019 at 08:26, (Exiting) Baolin Wang > <baolin.wang@xxxxxxxxxx> wrote: > > > > Hi Ulf, > > > > On Fri, 13 Dec 2019 at 09:53, (Exiting) Baolin Wang > > <baolin.wang@xxxxxxxxxx> wrote: > > > > > > Hi Ulf, > > > > > > On Thu, 12 Dec 2019 at 23:30, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > > > > > > > > [...] > > > > > > > > > > > > > Ulf, > > > > > > > > > > > > > > > > > > I am not sure if there is any chance to merge this patch set into > > > > > > > > > V5.5, I've tested for a long time and did not find any resession. > > > > > > > > > Thanks. > > > > > > > > > > > > > > > > Could you apply this patchset if no objection from your side? Or do > > > > > > > > you need me to rebase and resend? Thanks. > > > > > > > > > > > > > > Sorry for troubling you in this way. Just want to make sure you did > > > > > > > not miss my V7 patchset for the MMC software queue, since it was > > > > > > > pending for a while, and I got a consensus with Arnd and Adrian > > > > > > > finally. Could you apply them if no objection from your side? As we > > > > > > > talked before, there are some packed request support patches will > > > > > > > depend on the MMC software queue. Thanks a lot. > > > > > > > > > > > > Thanks for reminding me! Apologize for the delays, just been too busy! > > > > > > > > > > No worries, I understood :) > > > > > > > > > > > > > > > > > Sounds promising! Let me have a closer look, by the end of this week. > > > > > > > > > > OK. Thank you very much. > > > > > > > > Baolin, I am looking at your series, but I need some more time. Yes, > > > > even more, sorry. > > > > > > > > I am out most of tomorrow and the entire weekend, so it seems like I > > > > will have to continue reviewing on Monday. > > > > > > Thanks for letting me know the patches' status. OK, no problem. > > > > > > > Apologize for reminding you again. :) > > > > I know next week will be your holiday, not sure if this patch set will > > be still pending for another long time. And the idea of the solution > > was discussed with Arnd and you, so I thought we all got a consensus > > about how to add the packed request support step by step. Moreover > > this patch set will not impact the normal routine without enabling MMC > > software queue and I already did lots of stable testing (including > > request handling, tuning and recovering). > > Did you test system suspend/resume, while also having an ongoing > file/dd operations towards the mmc/sd card? Yes, I did and it can work. > > In any case, I am aware of the consensus - it looks promising. More > importantly, I appreciate the work you are doing here. Don't get me > wrong on that, even if I am causing these long an unacceptable delays > - sorry about that! > > I have spent most of my reviewing time this week, looking at your > series, but it's not a trivial review and I want to take my time to Thanks for spending time on this patch set. > review it thoroughly. And fore sure, I fully respects Arnd and Adrian > reviews that is made already. > > That said, I am sorry to disappoint you, but I am just not ready to > apply it yet. > > In regards to the holidays, don't worry, I will be working. Well, > except for those days that are public holidays in Sweden. :-) > > > > > We really want to use the packed request support with adding ADMA3 > > transfer mode to improve the IO performance on our platform ASAP, and > > I think we still have more work and potential discussion to add the > > packed request support (maybe need optimize the blk-mq to support > > batch requests handling), but as we discussed before, we should > > introduce the MMC software queue first, then I can move on to the next > > step. I am sorry again to troubling you. > > To help you out a bit in regards to this, I have hosted a separate > branch in my git tree that have the series applied (based on today's > "next" branch). The branch is namned "next_host_sq". I may decide to > merge it to next, to get some test coverage, but let's see about that. > > In any case, feel free to base AMDA3 (packed command) support on the > new branch, at least for now. Great, thanks for your help. -- Baolin Wang Best Regards
