-trimmed cc list On Wed, 18 Dec 2019 at 07:30, Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> wrote: > > On Sun 15 Dec 09:51 PST 2019, Yangtao Li wrote: > > > Use devm_platform_ioremap_resource() to simplify code. > > > > Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx> > > --- > > drivers/mmc/host/sdhci-msm.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > > index 3d0bb5e2e09b..6daacef4ceec 100644 > > --- a/drivers/mmc/host/sdhci-msm.c > > +++ b/drivers/mmc/host/sdhci-msm.c > > @@ -1746,7 +1746,6 @@ static int sdhci_msm_probe(struct platform_device *pdev) > > struct sdhci_host *host; > > struct sdhci_pltfm_host *pltfm_host; > > struct sdhci_msm_host *msm_host; > > - struct resource *core_memres; > > struct clk *clk; > > int ret; > > u16 host_version, core_minor; > > @@ -1847,9 +1846,7 @@ static int sdhci_msm_probe(struct platform_device *pdev) > > } > > > > if (!msm_host->mci_removed) { > > - core_memres = platform_get_resource(pdev, IORESOURCE_MEM, 1); > > - msm_host->core_mem = devm_ioremap_resource(&pdev->dev, > > - core_memres); > > + msm_host->core_mem = devm_platform_ioremap_resource(pdev, 1); > > > > This would now look better without this empty line. Good point, I fixed it when applying. No actions needed. > > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > [...] Kind regards Uffe