On Mon, 16 Dec 2019 at 09:02, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > On Fri, Dec 6, 2019 at 6:08 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > > > It has turned out that some mmc host drivers, but perhaps also others > > drivers, needs to reset the pinctrl into the default state > > (PINCTRL_STATE_DEFAULT). However, they can't use the existing > > pinctrl_pm_select_default_state(), as that requires CONFIG_PM to be set. > > This leads to open coding, as they need to look up the default state > > themselves and then select it. > > > > To avoid the open coding, let's introduce pinctrl_select_default_state() > > and make it available independently of CONFIG_PM. As a matter of fact, this > > makes it more consistent with the behaviour of the driver core, as it > > already tries to looks up the default state during probe. > > > > Going forward, users of pinctrl_pm_select_default_state() are encouraged to > > move to pinctrl_select_default_state(), so the old API can be removed. > > > > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > > I have put this patch on an immutable branch so that you can pull it into your > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=ib-pinctrl-default-state > > I also pulled this immutable branch into my "devel" branch for v5.6. > > I think other subsystems may need the same kind of stuff and I might need > to change code around here so I need to apply it to my tree. Thanks! I have pulled in the branch into my tree - and applied the mmc patches with your ack on top. Kind regards Uffe