Hi Wolfram-san, > From: Wolfram Sang, Sent: Wednesday, December 4, 2019 5:33 AM > > HW engineers say that automatic tap correction cannot be used for HS400 > in all R-Car Gen3 SoCs. So, check for that SDHI variant and disable it > when HS400 is about to be enabled. > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > --- > > The BSP handles this differently and adds a quirk entry to every > soc_device_match and checks the quirk entry. I chose this less intrusive > method because all Gen3 SoCs are affected. But not all SDHI instances, > only those which can access eMMC, of course. So, I likes this approach a > tad better. If you think all quirks should be centralized in the quirks > structure, I am open for discussion. Thank you for the patch! I agreed your choice. If we had a SoC which can use auto correction, we could add such a quirk at that timing :) So, Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> Best regards, Yoshihiro Shimoda
