On Fri, Nov 8, 2019 at 5:09 PM Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > From: Thierry Reding <treding@xxxxxxxxxx> > > According to the comment, board files used to specify 1 ms for the > debounce time. gpiod_set_debounce() needs the debounce time to be > specified in units of microseconds, so make sure to multiply the value > by 1000. > > Note that, according to the git log, the board files actually did > specify 1 us for bounce times, but that seems really low. Device tree > bindings for this type of GPIO typically specify the debounce times in > milliseconds, so setting this default value to 1 ms seems like it would > be somewhat safer. > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> Makes perfect sense. Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij
