I'm sorry that I have missed one of your previous comments. From your comments I'll create a more simple patch that takes the old bkops_en function that can set bit 0 and 1. The kernel driver checks for both AUTO_EN and MANUAL_EN in mmc_decode_ext_csd but only have to do something when MANUAL_EN is set in mmc_run_bkops. So I don't think the driver cares if we try to set both bits. But I also did test on a sandisk emmc where I could flip AUTO_EN back and forth. Setting the AUTO_EN bit stopped having an effect when I had set the MANUAL_EN bit. So maybe a line in the help section should mention this. On Mon, 4 Nov 2019 at 13:50, Avri Altman <Avri.Altman@xxxxxxx> wrote: > > Hi Lars, > > > > > The BKOPS_EN register in eMMC 5.1 now has two fields AUTO_EN and > > MANUAL_EN. > > > > Signed-off-by: Lars Pedersen <lapeddk@xxxxxxxxx> > You didn't responded to my previous comments - > See https://www.spinics.net/lists/linux-mmc/msg56320.html > Also, The 0/1 is no longer needed. > > Thanks, > Avri Kinds regards, Lars Pedersen
