On Sat, 19 Oct 2019 at 22:44, Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxxxxx> wrote: > > On Friday, October 18, 2019 13:54 -03, Zhou Yanjie <zhouyanjie@xxxxxxxx> wrote: > > > > > > > > > > I also have a general question. Should we perhaps rename the driver > > > from jz4740_mmc.c to ingenic.c (and the file for the DT bindings, the > > > Kconfig, etc), as that seems like a more appropriate name? No? > > > > I am very much in favor of this proposal. Now jz4740_mmc.c is not only used > > for the JZ4740 processor, it is also used for JZ4725, JZ4760, JZ4770, JZ4780 > > and X1000, and now Ingenic's processor is no longer named after JZ47xx, > > it is divided into three product lines: M, T, and X. It is easy to cause > > some > > misunderstandings by using jz4740_mmc.c. At the same time, I think that > > some register names also need to be adjusted. For example, the STLPPL > > register name has only appeared in JZ4730 and JZ4740, and this register > > in all subsequent processors is called CTRL. This time I was confused by > > the STLPPL when I added drivers for the JZ4760's and X1000's LPM. > > > > I am very much against renamings, for several reasons. As Paul already mentioned, it's pointless and just adds noise to the git-log, making history harder to recover. Driver file names don't really have to reflect the device > > exactly. For the compatibility list, it's far easier to just git-grep for compatible strings, or git-grep Documentation and/or Kconfig. I have no strong opinions. What matters to me, is that people agree on the best option, based on a case by case discussion. > > Renaming macros and register names, is equally pointless and equally git-history invasive. Simply adding some documentation is enough. Sounds like documentation is what people prefer here - and the DT doc seems already fine in regards to that. Perhaps some more words added to the header in driver's c-file could be and option to consider, as today it only mentions "JZ4740 SD/MMC controller driver". Anyway, it's up to you. :-) Kind regards Uffe
