Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on pm/linux-next] [cannot apply to v5.3 next-20190920] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ACPI-utils-Describe-function-parameters-in-kernel-doc/20190924-230504 base: https://kernel.googlesource.com/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=ia64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All error/warnings (new ones prefixed by >>): In file included from include/linux/acpi.h:32:0, from include/linux/i2c.h:13, from drivers//media/radio/si4713/si4713.c:15: >> include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~ -- In file included from include/linux/acpi.h:32:0, from drivers/acpi/utils.c:15: >> include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~ >> drivers/acpi/utils.c:713:6: error: conflicting types for 'acpi_dev_hid_uid_match' bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/acpi.h:32:0, from drivers/acpi/utils.c:15: include/acpi/acpi_bus.h:78:6: note: previous declaration of 'acpi_dev_hid_uid_match' was here bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/linkage.h:7:0, from include/linux/kernel.h:8, from drivers/acpi/utils.c:9: drivers/acpi/utils.c:727:15: error: conflicting types for 'acpi_dev_hid_uid_match' EXPORT_SYMBOL(acpi_dev_hid_uid_match); ^ include/linux/export.h:79:21: note: in definition of macro '___EXPORT_SYMBOL' extern typeof(sym) sym; \ ^~~ >> drivers/acpi/utils.c:727:1: note: in expansion of macro 'EXPORT_SYMBOL' EXPORT_SYMBOL(acpi_dev_hid_uid_match); ^~~~~~~~~~~~~ In file included from include/linux/acpi.h:32:0, from drivers/acpi/utils.c:15: include/acpi/acpi_bus.h:78:6: note: previous declaration of 'acpi_dev_hid_uid_match' was here bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~~~~~~~~~~~~ -- In file included from include/linux/acpi.h:32:0, from drivers/cpufreq/ia64-acpi-cpufreq.c:24: >> include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~ drivers/cpufreq/ia64-acpi-cpufreq.c: In function 'processor_set_pstate': <command-line>:0:16: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 's64 {aka long long int}' [-Wformat=] drivers/cpufreq/ia64-acpi-cpufreq.c:12:21: note: in expansion of macro 'KBUILD_MODNAME' #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt ^~~~~~~~~~~~~~ include/linux/dynamic_debug.h:125:15: note: in expansion of macro 'pr_fmt' func(&id, ##__VA_ARGS__); \ ^~~~~~~~~~~ include/linux/dynamic_debug.h:143:2: note: in expansion of macro '__dynamic_func_call' __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:153:2: note: in expansion of macro '_dynamic_func_call' _dynamic_func_call(fmt, __dynamic_pr_debug, \ ^~~~~~~~~~~~~~~~~~ include/linux/printk.h:336:2: note: in expansion of macro 'dynamic_pr_debug' dynamic_pr_debug(fmt, ##__VA_ARGS__) ^~~~~~~~~~~~~~~~ drivers/cpufreq/ia64-acpi-cpufreq.c:57:3: note: in expansion of macro 'pr_debug' pr_debug("Failed to set freq to 0x%x, with error 0x%lx\n", ^~~~~~~~ drivers/cpufreq/ia64-acpi-cpufreq.c: In function 'processor_get_pstate': <command-line>:0:16: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 's64 {aka long long int}' [-Wformat=] drivers/cpufreq/ia64-acpi-cpufreq.c:12:21: note: in expansion of macro 'KBUILD_MODNAME' #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt ^~~~~~~~~~~~~~ include/linux/dynamic_debug.h:125:15: note: in expansion of macro 'pr_fmt' func(&id, ##__VA_ARGS__); \ ^~~~~~~~~~~ include/linux/dynamic_debug.h:143:2: note: in expansion of macro '__dynamic_func_call' __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:153:2: note: in expansion of macro '_dynamic_func_call' _dynamic_func_call(fmt, __dynamic_pr_debug, \ ^~~~~~~~~~~~~~~~~~ include/linux/printk.h:336:2: note: in expansion of macro 'dynamic_pr_debug' dynamic_pr_debug(fmt, ##__VA_ARGS__) ^~~~~~~~~~~~~~~~ drivers/cpufreq/ia64-acpi-cpufreq.c:79:3: note: in expansion of macro 'pr_debug' pr_debug("Failed to get current freq with " ^~~~~~~~ -- In file included from include/linux/acpi.h:32:0, from drivers//acpi/utils.c:15: >> include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~ drivers//acpi/utils.c:713:6: error: conflicting types for 'acpi_dev_hid_uid_match' bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/acpi.h:32:0, from drivers//acpi/utils.c:15: include/acpi/acpi_bus.h:78:6: note: previous declaration of 'acpi_dev_hid_uid_match' was here bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/linkage.h:7:0, from include/linux/kernel.h:8, from drivers//acpi/utils.c:9: drivers//acpi/utils.c:727:15: error: conflicting types for 'acpi_dev_hid_uid_match' EXPORT_SYMBOL(acpi_dev_hid_uid_match); ^ include/linux/export.h:79:21: note: in definition of macro '___EXPORT_SYMBOL' extern typeof(sym) sym; \ ^~~ drivers//acpi/utils.c:727:1: note: in expansion of macro 'EXPORT_SYMBOL' EXPORT_SYMBOL(acpi_dev_hid_uid_match); ^~~~~~~~~~~~~ In file included from include/linux/acpi.h:32:0, from drivers//acpi/utils.c:15: include/acpi/acpi_bus.h:78:6: note: previous declaration of 'acpi_dev_hid_uid_match' was here bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~~~~~~~~~~~~ -- In file included from include/linux/acpi.h:32:0, from drivers//cpufreq/ia64-acpi-cpufreq.c:24: >> include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~ drivers//cpufreq/ia64-acpi-cpufreq.c: In function 'processor_set_pstate': <command-line>:0:16: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 's64 {aka long long int}' [-Wformat=] drivers//cpufreq/ia64-acpi-cpufreq.c:12:21: note: in expansion of macro 'KBUILD_MODNAME' #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt ^~~~~~~~~~~~~~ include/linux/dynamic_debug.h:125:15: note: in expansion of macro 'pr_fmt' func(&id, ##__VA_ARGS__); \ ^~~~~~~~~~~ include/linux/dynamic_debug.h:143:2: note: in expansion of macro '__dynamic_func_call' __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:153:2: note: in expansion of macro '_dynamic_func_call' _dynamic_func_call(fmt, __dynamic_pr_debug, \ ^~~~~~~~~~~~~~~~~~ include/linux/printk.h:336:2: note: in expansion of macro 'dynamic_pr_debug' dynamic_pr_debug(fmt, ##__VA_ARGS__) ^~~~~~~~~~~~~~~~ drivers//cpufreq/ia64-acpi-cpufreq.c:57:3: note: in expansion of macro 'pr_debug' pr_debug("Failed to set freq to 0x%x, with error 0x%lx\n", ^~~~~~~~ drivers//cpufreq/ia64-acpi-cpufreq.c: In function 'processor_get_pstate': <command-line>:0:16: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 's64 {aka long long int}' [-Wformat=] drivers//cpufreq/ia64-acpi-cpufreq.c:12:21: note: in expansion of macro 'KBUILD_MODNAME' #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt ^~~~~~~~~~~~~~ include/linux/dynamic_debug.h:125:15: note: in expansion of macro 'pr_fmt' func(&id, ##__VA_ARGS__); \ ^~~~~~~~~~~ include/linux/dynamic_debug.h:143:2: note: in expansion of macro '__dynamic_func_call' __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:153:2: note: in expansion of macro '_dynamic_func_call' _dynamic_func_call(fmt, __dynamic_pr_debug, \ ^~~~~~~~~~~~~~~~~~ include/linux/printk.h:336:2: note: in expansion of macro 'dynamic_pr_debug' dynamic_pr_debug(fmt, ##__VA_ARGS__) ^~~~~~~~~~~~~~~~ drivers//cpufreq/ia64-acpi-cpufreq.c:79:3: note: in expansion of macro 'pr_debug' pr_debug("Failed to get current freq with " ^~~~~~~~ -- In file included from include/linux/acpi.h:32:0, from include/linux/i2c.h:13, from include/media/dvb_frontend.h:38, from drivers/media/tuners/mxl5005s.c:66: >> include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~ drivers/media/tuners/mxl5005s.c: In function 'MXL5005_ControlInit.isra.2': drivers/media/tuners/mxl5005s.c:1660:1: warning: the frame size of 4448 bytes is larger than 2048 bytes [-Wframe-larger-than=] } ^ -- In file included from include/linux/acpi.h:32:0, from include/linux/i2c.h:13, from include/media/dvb_frontend.h:38, from drivers//media/tuners/mxl5005s.c:66: >> include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration bool acpi_dev_hid_uid_match(struct acpi_device *adev, ^~~~~~~~~~~ drivers//media/tuners/mxl5005s.c: In function 'MXL5005_ControlInit.isra.2': drivers//media/tuners/mxl5005s.c:1660:1: warning: the frame size of 4448 bytes is larger than 2048 bytes [-Wframe-larger-than=] } ^ vim +/acpi_dev_hid_uid_match +713 drivers/acpi/utils.c 703 704 /** 705 * acpi_dev_hid_uid_match - Match device by supplied HID and UID 706 * @adev: ACPI device to match. 707 * @hid2: Hardware ID of the device. 708 * @uid2: Unique ID of the device, pass NULL to not check _UID. 709 * 710 * Matches HID and UID in @adev with given @hid2 and @uid2. 711 * Returns true if matches. 712 */ > 713 bool acpi_dev_hid_uid_match(struct acpi_device *adev, 714 const char *hid2, const char *uid2) 715 { 716 const char *hid1 = acpi_device_hid(adev); 717 const char *uid1 = acpi_device_uid(adev); 718 719 if (strcmp(hid1, hid2)) 720 return false; 721 722 if (!uid2) 723 return true; 724 725 return uid1 && !strcmp(uid1, uid2); 726 } > 727 EXPORT_SYMBOL(acpi_dev_hid_uid_match); 728 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
