Hello, On 18/09/2019 22:58:23+0530, Saiyam Doshi wrote: > Use false/true instead of 0/1 in bool variable assignment. > > This fixes below coccicheck warning. > "WARNING: Assignment of 0/1 to bool variable" > > Generated by: scripts/coccinelle/misc/boolinit.cocci > > More information about semantic patching is available at > http://coccinelle.lip6.fr/ > More useful than information than info on semantic patching, it would be good to have info on why you feel this is necessary. > Signed-off-by: Saiyam Doshi <saiyamdoshi.in@xxxxxxxxx> > --- > drivers/mmc/host/atmel-mci.c | 50 ++++++++++++++++++------------------ > 1 file changed, 25 insertions(+), 25 deletions(-) > > diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c > index c26fbe5f2222..91088b1712ae 100644 > --- a/drivers/mmc/host/atmel-mci.c > +++ b/drivers/mmc/host/atmel-mci.c > @@ -706,7 +706,7 @@ static void atmci_timeout_timer(struct timer_list *t) > host->mrq->cmd->error = -ETIMEDOUT; > host->cmd = NULL; > } > - host->need_reset = 1; > + host->need_reset = true; > host->state = STATE_END_REQUEST; > smp_wmb(); > tasklet_schedule(&host->tasklet); > @@ -1610,7 +1610,7 @@ static void atmci_command_complete(struct atmel_mci *host, > else if (host->mrq->data && (host->mrq->data->blksz & 3)) { > if (host->caps.need_blksz_mul_4) { > cmd->error = -EINVAL; > - host->need_reset = 1; > + host->need_reset = true; > } > } else > cmd->error = 0; > @@ -2396,45 +2396,45 @@ static void atmci_get_cap(struct atmel_mci *host) > dev_info(&host->pdev->dev, > "version: 0x%x\n", version); > > - host->caps.has_dma_conf_reg = 0; > - host->caps.has_pdc = 1; > - host->caps.has_cfg_reg = 0; > - host->caps.has_cstor_reg = 0; > - host->caps.has_highspeed = 0; > - host->caps.has_rwproof = 0; > - host->caps.has_odd_clk_div = 0; > - host->caps.has_bad_data_ordering = 1; > - host->caps.need_reset_after_xfer = 1; > - host->caps.need_blksz_mul_4 = 1; > - host->caps.need_notbusy_for_read_ops = 0; > + host->caps.has_dma_conf_reg = false; > + host->caps.has_pdc = true; > + host->caps.has_cfg_reg = false; > + host->caps.has_cstor_reg = false; > + host->caps.has_highspeed = false; > + host->caps.has_rwproof = false; > + host->caps.has_odd_clk_div = false; > + host->caps.has_bad_data_ordering = true; > + host->caps.need_reset_after_xfer = true; > + host->caps.need_blksz_mul_4 = true; > + host->caps.need_notbusy_for_read_ops = false; > > /* keep only major version number */ > switch (version & 0xf00) { > case 0x600: > case 0x500: > - host->caps.has_odd_clk_div = 1; > + host->caps.has_odd_clk_div = true; > /* Fall through */ > case 0x400: > case 0x300: > - host->caps.has_dma_conf_reg = 1; > - host->caps.has_pdc = 0; > - host->caps.has_cfg_reg = 1; > - host->caps.has_cstor_reg = 1; > - host->caps.has_highspeed = 1; > + host->caps.has_dma_conf_reg = true; > + host->caps.has_pdc = false; > + host->caps.has_cfg_reg = true; > + host->caps.has_cstor_reg = true; > + host->caps.has_highspeed = true; > /* Fall through */ > case 0x200: > - host->caps.has_rwproof = 1; > - host->caps.need_blksz_mul_4 = 0; > - host->caps.need_notbusy_for_read_ops = 1; > + host->caps.has_rwproof = true; > + host->caps.need_blksz_mul_4 = false; > + host->caps.need_notbusy_for_read_ops = true; > /* Fall through */ > case 0x100: > - host->caps.has_bad_data_ordering = 0; > - host->caps.need_reset_after_xfer = 0; > + host->caps.has_bad_data_ordering = false; > + host->caps.need_reset_after_xfer = false; > /* Fall through */ > case 0x0: > break; > default: > - host->caps.has_pdc = 0; > + host->caps.has_pdc = false; > dev_warn(&host->pdev->dev, > "Unmanaged mci version, set minimum capabilities\n"); > break; > -- > 2.20.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
