On 2019-08-26 08:39, Ulf Hansson wrote:
Finally, this Sandisk A2 card doesn't have the LV logo on it, so I
don't know whether it would support 1.8V operation if the LVS
negotiation was done directly or not - and I don't know whether
setting
bit 7 in OCR is correct for an LV compliant card.
Yeah.
I think we can agree on that having bit7 set in OCR is not really
useful for SD card. In principle I think we should just just ignore it
for all SD cards.
Do you want to send a patch, or if you prefer, I can do it!?
I started looking at how we might make a general change to ignore for
all
cards, and in the process, I saw that we already have a way to
differentiate
ocr_avail for different card types, and the sdhci driver uses this to
elide the low voltage range when dealing with SD cards. So I've made the
small change to have the rtsx drivers set ocr_avail_sd and skip the low
voltage
range support. This makes the cards work, as you'd expect.
There's still a fair claim that the elidation logic should move into the
core,
so that all host controllers automatically benefit, but I think I should
leave
that to you. It's a core change and I don't pretend to understand all
the
considerations for all the various supported controllers.
I've sent a new diff with the rtsx-specific fix.
Thanks,
--phil
