+ Chaotian Jing On Tue, 20 Aug 2019 at 13:42, <ja.kaisrlik@xxxxxxxxx> wrote: > > From: Jan Kaisrlik <ja.kaisrlik@xxxxxxxxx> > > This reverts commit 3a0681c7448b174e5dcfd19e9079cdd281c35f1a. > > Turns out the patch breaks initialization of Toshiba THGBMNG5. > [ 1.648951] mmc0: mmc_select_hs200 failed, error -84 > [ 1.648988] mmc0: error -84 whilst initialising MMC card For exactly this reason, when getting CRC errors on the first attempt, doing a retry makes little sense. I have looped in Chaotian who has some more details about the problem. In any case, Jan, what HW and mmc controller are you using? > > Signed-off-by: Jan Kaisrlik <ja.kaisrlik@xxxxxxxxx> > --- > drivers/mmc/core/mmc_ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c > index 74e4364bc9fb..09113b9ad679 100644 > --- a/drivers/mmc/core/mmc_ops.c > +++ b/drivers/mmc/core/mmc_ops.c > @@ -564,7 +564,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value, > if (index == EXT_CSD_SANITIZE_START) > cmd.sanitize_busy = true; > > - err = mmc_wait_for_cmd(host, &cmd, 0); > + err = mmc_wait_for_cmd(host, &cmd, MMC_CMD_RETRIES); > if (err) > goto out; > > -- > 2.20.1 > Kind regards Uffe
