Hi, On Wed, Jul 24, 2019 at 4:35 AM Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > > Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > > As described in the patch ("mmc: core: Add sdio_trigger_replug() > > API"), the current mwifiex_sdio_card_reset() is broken in the cases > > where we're running Bluetooth on a second SDIO func on the same card > > as WiFi. The problem goes away if we just use the > > sdio_trigger_replug() API call. > > > > NOTE: Even though with this new solution there is less of a reason to > > do our work from a workqueue (the unplug / plug mechanism we're using > > is possible for a human to perform at any time so the stack is > > supposed to handle it without it needing to be called from a special > > context), we still need a workqueue because the Marvell reset function > > could called from a context where sleeping is invalid and thus we > > can't claim the host. One example is Marvell's wakeup_timer_fn(). > > > > Cc: Andreas Fenkart <afenkart@xxxxxxxxx> > > Cc: Brian Norris <briannorris@xxxxxxxxxxxx> > > Fixes: b4336a282db8 ("mwifiex: sdio: reset adapter using mmc_hw_reset") > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx> > > I assume this is going via some other tree so I'm dropping this from my > queue. If I should apply this please resend once the dependency is in > wireless-drivers-next. > > Patch set to Not Applicable. Thanks. For now I'll assume that Ulf will pick it up if/when he is happy with patch #1 in this series. Would you be willing to provide your Ack on this patch to make it clear to Ulf you're OK with that? -Doug