Re: [PATCH 1/2] mmc: mmci: Drop re-read of MMCISTATUS for busy status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 15, 2019 at 6:42 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:

> The MMCISTATUS register is read from the IRQ handler, mmci_irq(). For
> processing, its value is then passed as an in-parameter to mmci_cmd_irq().
>
> When dealing with busy detection, the MMCISTATUS register is being re-read,
> as to retrieve an updated value. However, this operation is likely costing
> more than it benefits, as the value was read only a few cycles ago. For
> this reason, let's simply drop the re-read and use the value from the
> in-parameter instead.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij



[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux