Hi! On Tue, May 28, 2019 at 09:32:31PM +0200, Ulf Hansson wrote: > On Tue, 28 May 2019 at 19:26, Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > On Tue, May 28, 2019 at 10:40:16AM +0200, Ulf Hansson wrote: > > > > +patternProperties: > > > > + "^.*@[0-9]+$": > > > > + properties: > > > > + reg: > > > > + items: > > > > + - minimum: 0 > > > > + maximum: 7 > > > > + description: > > > > + Must contain the SDIO function number of the function this > > > > + subnode describes. A value of 0 denotes the memory SD > > > > + function, values from 1 to 7 denote the SDIO functions. > > > > + > > > > + broken-hpi: > > > > + $ref: /schemas/types.yaml#/definitions/flag > > > > + description: > > > > + Use this to indicate that the mmc-card has a broken hpi > > > > + implementation, and that hpi should not be used. > > > > + > > > > + required: > > > > + - reg > > > > + > > > > > > [...] > > > > > > > -Use of Function subnodes > > > > ------------------------- > > > > - > > > > -On embedded systems the cards connected to a host may need additional > > > > -properties. These can be specified in subnodes to the host controller node. > > > > -The subnodes are identified by the standard 'reg' property. > > > > -Which information exactly can be specified depends on the bindings for the > > > > -SDIO function driver for the subnode, as specified by the compatible string. > > > > - > > > > -Required host node properties when using function subnodes: > > > > -- #address-cells: should be one. The cell is the slot id. > > > > -- #size-cells: should be zero. > > > > - > > > > -Required function subnode properties: > > > > -- reg: Must contain the SDIO function number of the function this subnode > > > > - describes. A value of 0 denotes the memory SD function, values from > > > > - 1 to 7 denote the SDIO functions. > > > > - > > > > -Optional function subnode properties: > > > > -- compatible: name of SDIO function following generic names recommended practice > > > > - > > > > > > I think most of the information of how we use sub(child) nodes > > > disappeared in this conversion - or at least gets harder to > > > understand. Could we perhaps keep some of this? > > > > Sure, what would you like to keep in particular? > > Most of it, so we can understand what can be described in sub-nodes. I've pushed a new version that keeps everything, I guess. > Additionally, we should also include what is stated in > Documentation/devicetree/bindings/mmc/mmc-card.txt, as that also > refers to how subnodes should be used, when it has the "mmc-card" > compatible. > > Or maybe we should simply move all things related to subnodes into a > separate .yaml? Yeah, this should be a separate YAML schema. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
