On Wed, May 08, 2019 at 11:04:56PM -0700, Christoph Hellwig wrote: > On Wed, May 08, 2019 at 12:58:32PM -0600, Raul E Rangel wrote: > > It is possible for queuedata to be cleared in mmc_cleanup_queue before > > the request has been started. > > Errm. I think we need to fix that problem instead of working around it. So mmc_request_fn already has a null check, it was just missing on mmc_init_request. I could move `blk_cleanup_queue(q)` above `q->queuedata = NULL` and the lock. So that would mean cherry-picking https://lore.kernel.org/patchwork/patch/856512/ and then a patch with moving blk_cleanup_queue. Should I do that instead? Thanks, Raul
