On Thu, May 9, 2019 at 3:21 AM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > The MMC controllers have a bunch of generic options that are needed in a > device tree. Add a YAML schemas for those. > > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxx> > --- > Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 342 +++++++- > Documentation/devicetree/bindings/mmc/mmc.txt | 177 +---- > 2 files changed, 342 insertions(+), 177 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mmc/mmc-controller.yaml > delete mode 100644 Documentation/devicetree/bindings/mmc/mmc.txt > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > new file mode 100644 > index 000000000000..d06f1764f02e > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > @@ -0,0 +1,342 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/mmc-controller.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: SPI Controller Generic Binding SPI? > + > +maintainers: > + - Ulf Hansson <ulf.hansson@xxxxxxxxxx> > + > +description: | > + These properties are common to multiple MMC host controllers. Any host > + that requires the respective functionality should implement them using > + these definitions. > + > +properties: > + $nodename: > + pattern: "^mmc(@.*)?$" > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + # Card Detection. > + # If none of these properties are supplied, the host native card > + # detect will be used. Only one of them should be provided. > + > + broken-cd: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + There is no card detection available; polling must be used. > + > + cd-gpios: > + description: > + The card detection will be done using the GPIO provided. > + > + non-removable: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Non-removable slot (like eMMC); assume always present. > + > + # Other properties > + > + bus-width: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - enum: [1, 4, 8] > + - default: 1 This works, but make enum and default a single schema. > + description: > + Number of data lines. > + > + max-frequency: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 400000 > + - maximum: 200000000 > + description: > + Maximum operating frequency of the bus. > + > + disable-wp: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + When set, no physical write-protect line is present. This > + property should only be specified when the controller has a > + dedicated write-protect detection logic. If a GPIO is always > + used for the write-protect detection. If a GPIO is always used > + for the write-protect detection logic, it is sufficient to not > + specify the wp-gpios property in the absence of a write-protect > + line. > + > + wp-inverted: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The CD line polarity is inverted. s/CD/write protect/ > + > + wp-gpios: > + description: > + GPIO to use for the write-protect detection. > + > + cd-debounce-delay-ms: > + $ref: /schemas/types.yaml#/definitions/uint32 Anything using a unit suffix is already typed. > + description: > + Set delay time before detecting card after card insert > + interrupt. > + > + cd-inverted: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The CD line polarity is inverted. > + > + no-1-8-v: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + When specified, denotes that 1.8V card voltage is not supported > + on this system, even if the controller claims it. > + > + cap-sd-highspeed: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + SD high-speed timing is supported. > + > + cap-mmc-highspeed: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + MMC high-speed timing is supported. > + > + sd-uhs-sdr12: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + SD UHS SDR12 speed is supported. > + > + sd-uhs-sdr25: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + SD UHS SDR25 speed is supported. > + > + sd-uhs-sdr50: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + SD UHS SDR50 speed is supported. > + > + sd-uhs-sdr104: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + SD UHS SDR104 speed is supported. > + > + sd-uhs-ddr50: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + SD UHS DDR50 speed is supported. > + > + cap-power-off-card: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Powering off the card is safe. > + > + cap-mmc-hw-reset: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + eMMC hardware reset is supported > + > + cap-sdio-irq: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + enable SDIO IRQ signalling on this interface > + > + full-pwr-cycle: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Full power cycle of the card is supported. > + > + mmc-ddr-1_2v: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + eMMC high-speed DDR mode (1.2V I/O) is supported. > + > + mmc-ddr-1_8v: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + eMMC high-speed DDR mode (1.8V I/O) is supported. > + > + mmc-ddr-3_3v: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + eMMC high-speed DDR mode (3.3V I/O) is supported. > + > + mmc-hs200-1_2v: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + eMMC HS200 mode (1.2V I/O) is supported. > + > + mmc-hs200-1_8v: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + eMMC HS200 mode (1.8V I/O) is supported. > + > + mmc-hs400-1_2v: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + eMMC HS400 mode (1.2V I/O) is supported. > + > + mmc-hs400-1_8v: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + eMMC HS400 mode (1.8V I/O) is supported. > + > + mmc-hs400-enhanced-strobe: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + eMMC HS400 enhanced strobe mode is supported > + > + dsr: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 0 > + - maximum: 65535 0xffff is clearer IMO > + description: > + Value the card Driver Stage Register (DSR) should be programmed > + with. > + > + no-sdio: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Controller is limited to send SDIO commands during > + initialization. > + > + no-sd: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Controller is limited to send SD commands during initialization. > + > + no-mmc: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Controller is limited to send MMC commands during > + initialization. > + > + fixed-emmc-driver-type: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 0 > + - maximum: 4 > + description: > + For non-removable eMMC, enforce this driver type. The value is > + the driver type as specified in the eMMC specification (table > + 206 in spec version 5.1) > + > + post-power-on-delay-ms: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - default: 10 > + description: > + It was invented for MMC pwrseq-simple which could be referred to > + mmc-pwrseq-simple.txt. But now it\'s reused as a tunable delay > + waiting for I/O signalling and card power supply to be stable, > + regardless of whether pwrseq-simple is used. Default to 10ms if > + no available. > + > + supports-cqe: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The presence of this property indicates that the corresponding > + MMC host controller supports HW command queue feature. > + > + disable-cqe-dcmd: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The presence of this property indicates that the MMC > + controller\'s command queue engine (CQE) does not support direct > + commands (DCMDs). > + > + keep-power-in-suspend: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + SDIO only. Preserves card power during a suspend/resume cycle. > + > + # Deprecated: enable-sdio-wakeup > + wakeup-source: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + SDIO only. Enables wake up of host system on SDIO IRQ assertion. > + > + vmmc-supply: > + description: > + Supply for the card power > + > + vqmmc-supply: > + description: > + Supply for the bus IO line power > + > + mmc-pwrseq: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + System-on-Chip designs may specify a specific MMC power > + sequence. To successfully detect an (e)MMC/SD/SDIO card, that > + power sequence must be maintained while initializing the card. > + > +patternProperties: > + "^.*@[0-9]+$": > + properties: > + reg: > + maxItems: 1 > + minimum: 0 > + maximum: 7 I don't think this works. You need: reg: items: - description: Must contain the SDIO function number of the function this subnode describes. A value of 0 denotes the memory SD function, values from 1 to 7 denote the SDIO functions. minimum: 0 maximum: 7 > + description: > + Must contain the SDIO function number of the function this > + subnode describes. A value of 0 denotes the memory SD > + function, values from 1 to 7 denote the SDIO functions. > + > + broken-hpi: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Use this to indicate that the mmc-card has a broken hpi > + implementation, and that hpi should not be used. > + > + required: > + - reg > + > +dependencies: > + cd-inverted: [ cd-gpios ] The note (which you dropped) says 'cd-inverted' applies for built-in CD too. At least that is what I take "Polarity of dedicated pins can be specified, using *-inverted properties." to mean. > + cd-debounce-delay-ms: [ cd-gpios ] > + wp-inverted: [ wp-gpios ] > + fixed-emmc-driver-type: [ non-removable ] > + > +examples: > + - | > + sdhci@ab000000 { > + compatible = "sdhci"; > + reg = <0xab000000 0x200>; > + interrupts = <23>; > + bus-width = <4>; > + cd-gpios = <&gpio 69 0>; > + cd-inverted; > + wp-gpios = <&gpio 70 0>; > + max-frequency = <50000000>; > + keep-power-in-suspend; > + wakeup-source; > + mmc-pwrseq = <&sdhci0_pwrseq>; > + }; > + > + - | > + mmc3: mmc@1c12000 { > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc3_pins_a>; > + vmmc-supply = <®_vmmc3>; > + bus-width = <4>; > + non-removable; > + mmc-pwrseq = <&sdhci0_pwrseq>; > + > + brcmf: bcrmf@1 { > + reg = <1>; > + compatible = "brcm,bcm43xx-fmac"; > + interrupt-parent = <&pio>; > + interrupts = <10 8>; > + interrupt-names = "host-wake"; > + }; > + };
