Thank you for reviewing my patches. Sorry for my late reply. Japan was in Spring Vacation. > On Fri, Apr 26, 2019 at 11:06:32AM +0900, Takao Orito wrote: > > Needs a commit msg. I see. I will add message. > > > Signed-off-by: Takao Orito <orito.takao@xxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/mmc/sdhci-milbeaut.txt | 35 ++++++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt > > > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt > > new file mode 100644 > > index 0000000..7008462 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt > > @@ -0,0 +1,35 @@ > > +* SOCIONEXT SDHCI controller > > + > > +This file documents differences between the core properties in mmc.txt > > +and the properties used by the sdhci_milbeaut driver. > > + > > +Required properties: > > +- compatible: "socionext,milbeaut-m10v-sdhci-3.0" > > +- clocks: Must contain an entry for each entry in clock-names. It is a > > + list of phandles and clock-specifier pairs. > > + See ../clocks/clock-bindings.txt for details. > > +- clock-names: Should contain the following two entries: > > + "iface" - clock used for sdhci interface > > + "core" - core clock for sdhci controller > > + > > +Optional properties: > > +- vqmmc-supply: phandle to the regulator device tree node, mentioned > > + as the VCCQ/VDD_IO supply in the eMMC/SD specs. > > +- fujitsu,cmd-dat-delay-select: boolean property indicating that this host > > + requires the CMD_DAT_DELAY control to be enabled. > > +- sni,mmc-power-gpio: set property indicating that power on or off needs > > + control of gpios. > > + > > +Example: > > + sdhci3: mmc@1b010000 { > > + compatible = "socionext,milbeaut-m10v-sdhci-3.0"; > > + reg = <0x1b010000 0x10000>; > > + interrupts = <0 265 0x4>; > > + voltage-ranges = <3300 3300>; > > + bus-width = <4>; > > + clocks = <&clk 7>, <&ahb_clk>; > > + clock-names = "core", "iface"; > > + cap-sdio-irq; > > + sni,mmc-power-gpio = <&pinctrl 53 GPIO_ACTIVE_HIGH>; > > + fujitsu,cmd-dat-delay-select; > > Whitespace problem. Sorry, I will fix. Thanks Orito > > > + }; > > -- > > 1.9.1 > > > > -- Takao Orito <orito.takao@xxxxxxxxxxxxx>