Hi Adrian, On 01/04/19 2:42 PM, Adrian Hunter wrote: > On 1/04/19 12:01 PM, Faiz Abbas wrote: >> Hi Adrian, >> >> On 01/04/19 2:21 PM, Adrian Hunter wrote: >>> On 29/03/19 4:22 PM, Faiz Abbas wrote: >>>> Some controllers on TI devices requires the HISPD bit to be cleared >>>> even in some high speed modes. Add a quirk that facilitates this >>>> requirement. >>> >>> Could you use sdhci I/O accessors for this? >> >> Can you elaborate? Not sure how this would be solved with >> CONFIG_MMC_SDHCI_IO_ACCESSORS. > > In ->writeb() > > if (reg == SDHCI_HOST_CONTROL) { > if (host->mmc->ios->timing == whatever) > val &= ~SDHCI_CTRL_HISPD; > } > > writeb(val, host->ioaddr + reg); This is a really good idea. Will use it in v2. Thanks. Regards, Faiz