Re: [ulf.hansson-mmc:next 35/43] drivers/mmc/host/mmci.c:965:1: error: expected ',' or ';' before 'void'

Ludovic BARRE <ludovic.barre@xxxxxx> · Fri, 29 Mar 2019 17:31:58 +0100

On 3/29/19 4:58 PM, Ulf Hansson wrote:
On Thu, 28 Mar 2019 at 23:10, kbuild test robot <lkp@xxxxxxxxx> wrote:

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next
head:   b97f38895d35f304e354fcc99a920c1f3332c758
commit: 066524f83ab8f23bcb115d3416ee7cff3845da01 [35/43] mmc: mmci: define get_dctrl_cfg for legacy variant
config: arm-vexpress_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
         chmod +x ~/bin/make.cross
         git checkout 066524f83ab8f23bcb115d3416ee7cff3845da01
         # save the attached .config to linux build tree
         GCC_VERSION=7.2.0 make.cross ARCH=arm

All error/warnings (new ones prefixed by >>):

drivers/mmc/host/mmci.c:965:1: error: expected ',' or ';' before 'void'
     void mmci_variant_init(struct mmci_host *host)
     ^~~~
drivers/mmc/host/mmci.c:49:13: warning: 'mmci_variant_init' used but never defined
     static void mmci_variant_init(struct mmci_host *host);
                 ^~~~~~~~~~~~~~~~~

vim +965 drivers/mmc/host/mmci.c

c3647fdc Ludovic Barre 2018-10-08  964
c3647fdc Ludovic Barre 2018-10-08 @965  void mmci_variant_init(struct mmci_host *host)
c3647fdc Ludovic Barre 2018-10-08  966  {
c3647fdc Ludovic Barre 2018-10-08  967          host->ops = &mmci_variant_ops;
c3647fdc Ludovic Barre 2018-10-08  968  }
066524f8 Ludovic Barre 2019-03-27  969

There were a missing ';' when CONFIG_DMA_ENGINE was unset. I fixed it
up by amending the offending patch, no actions need by you Ludovic.

thanks Ulf, sorry for the mistake.

Kind regards
Uffe