From: Ludovic Barre <ludovic.barre@xxxxxx> This patch series adds get_datactrl_cfg callback in mmci_host_ops to allow to get datactrl configuration specific at variant. change V4: -keep mmci and ux500v2 variant init in the c file. change V3: -keep the common functions in mmci_start_data. define function used by some variants like an helper (example mmci_dctrl_blks used by mmci and sdmmc). -To be consistent rename callback for ux500v2 change V2: -This V2 has been rebased on "mmc: mmci: Cleanup some variant related code" series -add helpers functions to define default datactrl value, each variant could use these helpers to define datactrl and adds their specific bits. -use static in qcom and stm32 -regroup mmci_(ux500v2)variant_init in header file to avoid checkpatch warning: "WARNING: externs should be avoided in .c files" -remove unused variant properties: "datactrl_dpsm_enable" "blksz_datactrl16" "blksz_datactrl4" Ludovic Barre (5): mmc: mmci: add get_datactrl_cfg callback and helper functions mmc: mmci: define get_dctrl_cfg for legacy variant mmc: mmci: qcom: define get_dctrl_cfg mmc: mmci: stm32: define get_dctrl_cfg mmc: mmci: replace blksz_datactrlXX by get_datactrl_cfg callback drivers/mmc/host/mmci.c | 56 +++++++++++++++++-------------------- drivers/mmc/host/mmci.h | 18 +++++++----- drivers/mmc/host/mmci_qcom_dml.c | 6 ++++ drivers/mmc/host/mmci_stm32_sdmmc.c | 18 ++++++++++++ 4 files changed, 61 insertions(+), 37 deletions(-) -- 2.7.4