From: Kangjie Lu <kjlu@xxxxxxx>
Date: Fri, 22 Mar 2019 22:24:19 -0500
> In case octeon_alloc_soft_command fails, the fix reports the
> error and goes to cleanup to avoid NULL pointer dereferences.
>
> Signed-off-by: Kangjie Lu <kjlu@xxxxxxx>
> ---
> V2: goto setup_nic_dev_free for cleanup
> ---
> drivers/mmc/host/mmc_spi.c | 2 +-
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 12 ++++++++++++
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
> index 32fea585262b..a3533935e282 100644
> --- a/drivers/mmc/host/mmc_spi.c
> +++ b/drivers/mmc/host/mmc_spi.c
> @@ -820,7 +820,7 @@ mmc_spi_readblock(struct mmc_spi_host *host, struct spi_transfer *t,
>
> status = spi_sync_locked(spi, &host->m);
> if (status < 0) {
> - dev_dbg(&spi->dev, "read error %02x (%d)\n", status, status);
> + dev_dbg(&spi->dev, "read error %d\n", status);
> return status;
> }
This is:
1) Unrelated to your bug fix.
2) It is often the case that people print values in hex and decimal
intentionally for debugging. I've done this myself countless
times.
