On Tue, Feb 19, 2019 at 06:06:55PM +0100, Wolfram Sang wrote: > On Mon, Feb 18, 2019 at 08:45:40PM +0300, Sergei Shtylyov wrote: > > I have encountered an interrupt storm during the eMMC chip probing (and > > the chip finally didn't get detected). It turned out that U-Boot left > > the DMAC interrupts enabled while the Linux driver didn't use those. > > The SDHI driver's interrupt handler somehow assumes that, even if an > > SDIO interrupt didn't happen, it should return IRQ_HANDLED. I think > > that if none of the enabled interrupts happened and got handled, we > > should return IRQ_NONE -- that way the kernel IRQ code recoginizes > > a spurious interrupt and masks it off pretty quickly... > > > > Fixes: 7729c7a232a9 ("mmc: tmio: Provide separate interrupt handlers") > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > > Tested on a Lager board (R-Car H2, microSD card) -> no regressions > Also, Salvator-XS (R-Car M3N, SDR50 SDIO WIFI card) > -> could still be detected > > Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > Tested-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>