Re: [PATCH] ARM: dts: exynos: Fix pinctrl definition for EMMC RTSN line on OdroidX2/U3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 24, 2019 at 01:22:57PM +0100, Marek Szyprowski wrote:
> Commit 225da7e65a03 ("ARM: dts: add eMMC reset line for
> exynos4412-odroid-common") added MMC power sequence for eMMC card. It
> reused generic sd1_cd pin control configuration node and only disabled
> pull-up. However that time the pinctrl configuration was not applied
> during MMC power sequence driver initialization. This has been changed
> later by commit d97a1e5d7cd2 ("mmc: pwrseq: convert to proper platform
> device").
> 
> It turned out then, that the provided pinctrl configuration is not
> correct, because the EMMC_RTSN line is being re-configured as 'special
> function/card detect function for mmc1 controller' not the simple
> 'output', thus the power sequence driver doesn't really set the pin
> value. Fix this by providing separate node with EMMC_RTSN pin
> configuration.
> 
> Reported-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx>
> Suggested-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Fixes: 225da7e65a03 ("ARM: dts: add eMMC reset line for exynos4412-odroid-common")
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 13 ++++++-------

Thanks, applied with cc-stable.

Best regards,
Krzysztof




[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux