Hi,
On 1/25/19 11:01, Loic Poulain wrote:
> Hi Koen,
>
> + Georgi
>
>> After bumping the kernel within OpenWrt to 4.14.95, a user reported a
>> build error on a specific platform (ipq806x):
>>
>> The reason is found within commit [1]: 4abb6960f61c ("mmc: sdhci-msm:
>> Disable CDR function on TX")
>>
>> which contains following hunk:
>>
>>
>> @@ -1107,6 +1155,7 @@ static const struct sdhci_ops sdhci_msm_ops = {
>> .set_bus_width = sdhci_set_bus_width,
>> .set_uhs_signaling = sdhci_msm_set_uhs_signaling,
>> .voltage_switch = sdhci_msm_voltage_switch,
>> + .write_w = sdhci_msm_write_w,
>> };
>> static const struct sdhci_pltfm_data sdhci_msm_pdata = {
>>
>>
>> Looking at the structure definition in sdhci.h, it seems this param is
>> optional, defined by symbol CONFIG_MMC_SDHCI_IO_ACCESSORS:
>>
>> Where in the assignment in this patch hunk, the assignment is not
>> conditional, resulting in the build failure.
>
> Yes, you're right, thanks for reporting this.
>
>> How should this properly be handled?
>> Should the assignment also be conditional depending on this symbol?
>
> This is a solution indeed, but I recommend to backport this patch instead:
> https://patchwork.kernel.org/patch/9973033/
> preventing the missing dependency.
Koen, sorry for that and thank you for reporting it! I agree with Loic.
>
> We now have to push it to the impacted stable branch(es).
Yes, it's only for v4.14, as the above patch is already present in
v4.15+. Will submit it to stable.
Thanks,
Georgi
