Re: [PATCH -next] mmc: block: fix debugfs_simple_attr.cocci warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 29 Dec 2018 at 02:36, YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
>
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
>
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
>
> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/core/block.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index aef1185..b08fb91 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -2774,8 +2774,8 @@ static int mmc_dbg_card_status_get(void *data, u64 *val)
>
>         return ret;
>  }
> -DEFINE_SIMPLE_ATTRIBUTE(mmc_dbg_card_status_fops, mmc_dbg_card_status_get,
> -               NULL, "%08llx\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(mmc_dbg_card_status_fops, mmc_dbg_card_status_get,
> +                        NULL, "%08llx\n");
>
>  /* That is two digits * 512 + 1 for newline */
>  #define EXT_CSD_STR_LEN 1025
> @@ -2863,8 +2863,9 @@ static int mmc_blk_add_debugfs(struct mmc_card *card, struct mmc_blk_data *md)
>
>         if (mmc_card_mmc(card) || mmc_card_sd(card)) {
>                 md->status_dentry =
> -                       debugfs_create_file("status", S_IRUSR, root, card,
> -                                           &mmc_dbg_card_status_fops);
> +                       debugfs_create_file_unsafe("status", 0400, root,
> +                                                  card,
> +                                                  &mmc_dbg_card_status_fops);
>                 if (!md->status_dentry)
>                         return -EIO;
>         }
>
>
>
>
>



[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux